Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add clamped Pockels calculation capability #67

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat: add clamped Pockels calculation capability #67

wants to merge 4 commits into from

Conversation

vdemestral
Copy link
Collaborator

I add the possibility of computing the clamped Pockels tensors into the VibroMixing class.

@cla-bot cla-bot
Copy link

cla-bot bot commented Jun 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot
Copy link

cla-bot bot commented Jun 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@vdemestral
Pockels code correction + test
cc0e0bc 
Corrected the calculation of the Pockels tensor after pytest
Added Pockels test-suite for AlAs
Removed unused variables after pytest
@cla-bot cla-bot
Copy link

cla-bot bot commented Jun 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

bastonero
bastonero requested changes Jun 13, 2024
View reviewed changes
Copy link
Owner

@bastonero bastonero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is awesome, thanks @vdemestral ! Just some minor changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastonero bastonero bastonero requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdemestral @bastonero